Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 upload coverge again when push commit. #175

Merged
merged 1 commit into from
Jun 8, 2023
Merged

🐛 upload coverge again when push commit. #175

merged 1 commit into from
Jun 8, 2023

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Jun 8, 2023 •
edited
Loading

Fixes

We should upload coverage again after PR merged at the time of pushing a commit.
Otherwise, the base branch will keep missing like this: #163 (comment)

Reference: https://github.com/codecov/example-go/blob/c76b419d5641077a561ebf807ca1f403af5c0bd3/.github/workflows/ci.yml#L3

@xuezhaojun
Add: upload coverge again when push commit.
d787784 
Signed-off-by: xuezhaojun <zxue@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and mikeshng June 8, 2023 07:46
@xuezhaojun xuezhaojun changed the title 🐛 🐛 bug fix: upload coverge again when push commit. 🐛 upload coverge again when push commit. Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@483612a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage        ?   58.49%           
=======================================
  Files           ?      107           
  Lines           ?    11836           
  Branches        ?        0           
=======================================
  Hits            ?     6923           
  Misses          ?     4242           
  Partials        ?      671
Flag Coverage Δ
unit 58.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6d4c488 into open-cluster-management-io:main Jun 8, 2023
ycyaoxdu pushed a commit to ycyaoxdu/ocm that referenced this pull request Jun 14, 2023
@qiujian16
Add informer setup for placemanifestwork (open-cluster-management-io#175
1703115 
)

- add index and informer to watch resources
- build binary for hub manager

Signed-off-by: Jian Qiu <jqiu@redhat.com>

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@xuezhaojun xuezhaojun deleted the upload-coverage-on-push branch December 19, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mikeshng mikeshng Awaiting requested review from mikeshng

Assignees

@qiujian16 qiujian16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuezhaojun @qiujian16 @openshift-merge-robot